netdev
[Top] [All Lists]

Re: [patch 1/2] cancel_rearming_delayed_work()

To: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, arjan@xxxxxxxxxxxxx
Subject: Re: [patch 1/2] cancel_rearming_delayed_work()
From: Andrew Morton <akpm@xxxxxxxx>
Date: Sun, 30 Jan 2005 22:41:49 -0800
In-reply-to: <200501310633.j0V6X0l01364@xxxxxxxxxxxxx>
References: <200501310633.j0V6X0l01364@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
akpm@xxxxxxxx wrote:
>
>  Add library functions to reliably kill off a delayed work whose handler
>  re-adds the delayed work.  One for keventd, one for caller-owned workqueues.
>  DESC
>  make cancel_rearming_delayed_workqueue static
>  EDESC
>  From: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
> 
>  cancel_rearming_delayed_workqueue() is only used inside workqueue.c; make
>  this function static (the more useful wrapper around it later in that
>  function remains non-static and exported)

hmm, actually, had I paid any attention to Arjan's patch I'd have dropped it ;)

cancel_rearming_delayed_workqueue() make sense and should be part of the
workqueue API, even if nothing uses it yet.

Whatever - we can fix that up sometime.

<Prev in Thread] Current Thread [Next in Thread>