netdev
[Top] [All Lists]

Re: LLTX fix proposal

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: LLTX fix proposal
From: jamal <hadi@xxxxxxxxxx>
Date: 30 Jan 2005 22:33:43 -0500
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20050130181854.7f088a95.davem@xxxxxxxxxxxxx>
Organization: jamalopolous
References: <20050130181854.7f088a95.davem@xxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 2005-01-30 at 21:18, David S. Miller wrote:
> Ok, how about we do this for 2.6.11 before it goes out and
> do something more sophisticated (if necessary) later.
> 
> The BUG() we're trying to catch in the ->hard_start_xmit()
> routines is the illegal state:
> 
>       driver_tx_queue_empty() && !netif_queue_stopped(dev)
> 

In the e1000 theres a lot more code in hard_start_xmit() that could
be possibly entered before you hit the xmit lock. So thats another
potential issue.
The tg3 you refer to in your email doesnt seem to be as bad and
i am actually wondering why what you just posted is _the fix_ as is.

cheers,
jamal




<Prev in Thread] Current Thread [Next in Thread>