Re: [PATCH] NETLINK: Use SKB_MAXORDER to calculate NLMSG_GOODSIZE

[Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>]

Hello!

> > -#define NLMSG_GOODSIZE (PAGE_SIZE - ((sizeof(struct sk_buff)+0xF)&~0xF))


... which reminded me about an old stale patchlet:


Comment: improper size calculation for collapsed skb size.
         Noticed by Denis V. Lunev <den@xxxxxxxxxxx>

===== net/ipv4/tcp_input.c 1.89 vs edited =====
--- 1.89/net/ipv4/tcp_input.c   Tue Jan 18 01:09:33 2005
+++ edited/net/ipv4/tcp_input.c Thu Jan 27 19:41:07 2005
@@ -3760,8 +3760,8 @@
        while (before(start, end)) {
                struct sk_buff *nskb;
                int header = skb_headroom(skb);
-               int copy = (PAGE_SIZE - sizeof(struct sk_buff) -
-                           sizeof(struct skb_shared_info) - header - 31)&~15;
+               int copy = (PAGE_SIZE - sizeof(struct skb_shared_info)
+                           - header - 31)&~15;
 
                /* Too big header? This can happen with IPv6. */
                if (copy < 0)