netdev
[Top] [All Lists]

Re: design for TSO performance fix

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: design for TSO performance fix
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 27 Jan 2005 21:19:40 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <E1CuKzJ-0001mY-00@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20050127163146.33b01e95.davem@xxxxxxxxxxxxx> <E1CuKzJ-0001mY-00@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 28 Jan 2005 12:31:53 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> > 2) As a result of #1, all the pcount crap goes away.
> >   The need for two MSS state variables (mss_cache,
> >   and mss_cache_std) and assosciated complexity is
> >   eliminated as well.
> 
> Does this mean that we'll start counting bytes instead
> of packets?
> 
> If not then please let me know on how you plan to do the
> packet counting.

Things will be same as what we have now, except multi-packet
SKBs will no longer exist in the retransmit queue.

> The other good thing about this is that if we do this for all
> packets including non-TSO ones, then the TCP stack doesn't have
> to own the TCP/IP headers at all.  Then we can stop worrying
> about the TSO/COW mangling.

Hmmm, have to think about that some more.

<Prev in Thread] Current Thread [Next in Thread>