Rusty Russell wrote: On Thu, 2005-01-27 at 17:10 -0800, David S. Miller wrote:In tree, yes. But leaving the NF_HOOK()/NF_HOOK_THRESH() compat macros in there for out-of-tree modules I feel is mandatory, it's a major API change.I'm not so sure. The hook functions which are registered, sure (ie. keep the calling convention the same). But do any external modules use NF_HOOK()? That implies they're writing their own network stack for some protocol, which I would expect to be uncommon. Freeswan comes to mind. But I guess one more #ifdef can't hurt :) Regards Patrick |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2.6.11-rc2 TCP ignores PMTU ICMP (Re: Linux 2.6.11-rc2), Patrick McHardy |
|---|---|
| Next by Date: | Re: on the wire behaviour of TSO on/off is supposed to be the same yes?, Rick Jones |
| Previous by Thread: | Re: [PATCH/RFC] Reduce call chain length in netfilter, Rusty Russell |
| Next by Thread: | [PATCH 2.6.10-bk9] pcnet32: 79c976 with fiber optic fix, Don Fry |
| Indexes: | [Date] [Thread] [Top] [All Lists] |