netdev
[Top] [All Lists]

Re: [PATCH]: was Re: LLTX and netif_stop_queue

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: [PATCH]: was Re: LLTX and netif_stop_queue
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Wed, 26 Jan 2005 23:22:27 -0800
Cc: buytenh@xxxxxxxxxxxxxx, shemminger@xxxxxxxx, roland@xxxxxxxxxxx, hadi@xxxxxxxxxx, iod00d@xxxxxx, eric.lemoine@xxxxxxxxx, netdev@xxxxxxxxxxx, ak@xxxxxxx, openib-general@xxxxxxxxxx, kaber@xxxxxxxxx
In-reply-to: <20050127071645.GA2731@xxxxxxxxxxxxx>
References: <20050119144711.3fdd3d93.davem@xxxxxxxxxxxxx> <20050119151853.259de49a@xxxxxxxxxxxxxxxxx> <20050119164640.6c67bdfa.davem@xxxxxxxxxxxxx> <52r7kgu5n5.fsf@xxxxxxxxxxx> <20050119230526.393a5184.davem@xxxxxxxxxxxxx> <20050120085611.33f9485e@xxxxxxxxxxxxxxxxx> <20050121105452.GA12988@xxxxxxxxxxxxxxxxx> <20050125222705.1ee878fd.davem@xxxxxxxxxxxxx> <20050126132512.GA18220@xxxxxxxxxxxxxxxxx> <20050126223247.3e4643cc.davem@xxxxxxxxxxxxx> <20050127071645.GA2731@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 27 Jan 2005 08:16:45 +0100
Andi Kleen <ak@xxxxxxx> wrote:

> > Yes, that's the idea.
> 
> per CPU only works in preemptive kernel if you have preemption
> disabled all the time. Do you? 
> 
> Seems not likely to me.

BH is disabled in these code paths (specifically we're talking
about ->hard_start_xmit()), as that is where the recursion
check goes.

Otherwise, loopback's LLTX is broken as it relies on this property
as well.

<Prev in Thread] Current Thread [Next in Thread>