|To:||Thomas Graf <tgraf@xxxxxxx>|
|From:||"David S. Miller" <davem@xxxxxxxxxxxxx>|
|Date:||Tue, 25 Jan 2005 12:50:19 -0800|
|Cc:||herbert@xxxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxxxxx, kaber@xxxxxxxxx, greearb@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx|
|References:||<20050124234515.GA31837@xxxxxxxxxxxxxx> <20050125000759.GA15883@xxxxxxxxxxxxxxxxxxx> <20050124164049.3b939791.davem@xxxxxxxxxxxxx> <20050125014538.GB31837@xxxxxxxxxxxxxx> <20050125014838.GA16637@xxxxxxxxxxxxxxxxxxx> <20050125020118.GC31837@xxxxxxxxxxxxxx> <20050124180354.63ae600d.davem@xxxxxxxxxxxxx> <20050125022431.GD31837@xxxxxxxxxxxxxx> <20050124194328.20a106de.davem@xxxxxxxxxxxxx> <20050125143319.GF31837@xxxxxxxxxxxxxx> <20050125203607.GG31837@xxxxxxxxxxxxxx>|
On Tue, 25 Jan 2005 21:36:07 +0100 Thomas Graf <tgraf@xxxxxxx> wrote: > NETIF_F_IP_CSUM|NETIF_F_HW_CSUM: > Assuming that the vlan accel code can always do the checksumming > if the card can do it. I bet there are cards that don't have VLAN hw assist yet can properly checksum such packets. One example I am counting on to fit this property is the 3c59x. This is why I'm suggesting some kind of inheritance indication explicitly from the real_dev driver. Perhaps even something like: unsigned int vlan_inherited_features; in the netdev struct. Basically, I don't want to preclude inheritance of checksumming capability just because the device doesn't have VLAN assist.
|<Prev in Thread]||Current Thread||[Next in Thread>|