netdev
[Top] [All Lists]

Re: skb_checksum_help

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: skb_checksum_help
From: David Coulson <david@xxxxxxxxxxxxxxxx>
Date: Tue, 25 Jan 2005 07:05:43 -0500
Cc: Thomas Graf <tgraf@xxxxxxx>, herbert@xxxxxxxxxxxxxxxxxxx, kaber@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050124194328.20a106de.davem@xxxxxxxxxxxxx>
References: <41F50B6C.6010107@xxxxxxxxxxxxxxxx> <20050124151510.GV23931@xxxxxxxxxxxxxx> <20050124225423.GA15405@xxxxxxxxxxxxxxxxxxx> <20050124234515.GA31837@xxxxxxxxxxxxxx> <20050125000759.GA15883@xxxxxxxxxxxxxxxxxxx> <20050124164049.3b939791.davem@xxxxxxxxxxxxx> <20050125014538.GB31837@xxxxxxxxxxxxxx> <20050125014838.GA16637@xxxxxxxxxxxxxxxxxxx> <20050125020118.GC31837@xxxxxxxxxxxxxx> <20050124180354.63ae600d.davem@xxxxxxxxxxxxx> <20050125022431.GD31837@xxxxxxxxxxxxxx> <20050124194328.20a106de.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041217
David S. Miller wrote:
For example, it probably only works properly when HW vlan assist
is being used on TX.  It's likely that the chips which don't support
VLAN assist also can't handle VLAN headers in their TX checksumming
engine.

This is in acenic.c - ACENIC_DO_VLAN is a check to see if 8021q is compiled into the kernel or available as a module.

#if ACENIC_DO_VLAN
        dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
        dev->vlan_rx_register = ace_vlan_rx_register;
        dev->vlan_rx_kill_vid = ace_vlan_rx_kill_vid;
#endif

David

--
David J. Coulson
email: david@xxxxxxxxxxxxxxxx
web: http://www.davidcoulson.net/
phone: (216) 920-3100 / (216) 258-4942

<Prev in Thread] Current Thread [Next in Thread>