netdev
[Top] [All Lists]

Re: [PATCH 2.6.10] tg3: Fix TSO for 5750

To: "Michael Chan" <mchan@xxxxxxxxxxxx>
Subject: Re: [PATCH 2.6.10] tg3: Fix TSO for 5750
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 24 Jan 2005 14:41:00 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <B1508D50A0692F42B217C22C02D84972020F3D42@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <B1508D50A0692F42B217C22C02D84972020F3D42@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 24 Jan 2005 13:51:36 -0800
"Michael Chan" <mchan@xxxxxxxxxxxx> wrote:

> - Fix TSO for 5750 chips by setting tcp checksum field to 0 for TSO packets
> - Add TG3_FLG2_HW_TSO flag for 5750 and newer chips that use the same TSO
> scheme

If we've created this new TG3_FLG2_HW_TSO flag, we should eliminate
all 5750 tests which are just checking for that.

For example, this patch leaves the following test:

-               if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705) {
+               if ((tp->tg3_flags2 & TG3_FLG2_HW_TSO) ||
+                   (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705)) {

Here, just checking the TG3_FLG3_HW_TSO flag would suffice.

<Prev in Thread] Current Thread [Next in Thread>