Re: [PATCH 1/6] PKT_SCHED: Extended Matches API

[Thomas Graf <tgraf@xxxxxxx>]

* Patrick McHardy <41F447CE.6030007@xxxxxxxxx> 2005-01-24 01:56
> Thomas Graf wrote:
> 
> >* Patrick McHardy <41F43D6D.30502@xxxxxxxxx> 2005-01-24 01:12
> > 
> >
> >>gcc assumes likely for ptr != NULL by default. Is there a reason why a 
> >>match
> >>wouldn't have a match function ?
> >>
> >
> >There is no reason but ematches might get written by unexperienced people
> >forgeting to register it. I know, the if partly hides the failure, it's
> >one of theses case where I have the same arguments for both ways.
> >
> I don't care much, but I guess people forgetting to add a match
> function to an ematch will find other ways to do stupid things :)
> How about catching it in tcf_em_register ?

Sounds like a good plan, will do so. Thanks.