On Sat, Jan 22, 2005 at 11:26:18PM +0100, Francois Romieu wrote:
> Daniele Venzano <webvenza@xxxxxxxxx> :
> > - printk(KERN_INFO "Cannot allocate mem for struct
> > mii_phy\n");
> > + printk(KERN_WARNING "Cannot allocate mem for struct
> > mii_phy\n");
>
> -> printk(KERN_WARNING "%s: Cannot allocate mem for struct mii_phy\n", ...) ?
>
> Btw it may make sense to use pci_name() instead of the name associated with
> the struct net_device until it is known for sure that the net_device will not
> be removed due to a failure of the probe() method.
Attached a patch on top of the previous ones.
It only fixes the missing prefix. I understand that pci_name could be a
better choice here, but I want to see what other drivers are doing in
their probe() before changing policy.
Signed-off-by: Daniele Venzano <webvenza@xxxxxxxxx>
--
-----------------------------
Daniele Venzano
Web: http://teg.homeunix.org
sis900_c_89.diff
Description: Text document
|