netdev
[Top] [All Lists]

Re: Acer Aspire 1524WLMi and RealTek 8169 - very slow

To: Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: Acer Aspire 1524WLMi and RealTek 8169 - very slow
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Sun, 23 Jan 2005 00:01:56 +0100
Cc: netdev@xxxxxxxxxxx
In-reply-to: <41F26FD1.2060407@xxxxxxxxxxxxxxxxxxxx>
References: <41A09541.5040405@xxxxxxxxxxxxxxxxxxxx> <41A0F0D5.9050702@xxxxxxxxxxxxxxxxxxxx> <20041121205814.GA22460@xxxxxxxxxxxxxxxxxxxxxxxxxx> <41A24F35.5080106@xxxxxxxxxxxxxxxxxxxx> <20041122213008.GA9618@xxxxxxxxxxxxxxxxxxxxxxxxxx> <41D2844E.5070204@xxxxxxxxxxxxxxxxxxxx> <20041229235203.GA5465@xxxxxxxxxxxxxxxxxxxxxxxxxx> <41F250D1.8000207@xxxxxxxxxxxxxxxxxxxx> <41F26FD1.2060407@xxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx> :
[...]
> So I looked at the latest RealTek driver for Linux (version 220) and 
> that has some separate initialisation code for RTL_GIGA_MAC_VER_X 
> (MCFG_METHOD_4, they call it). I ported that over to r8169.c in 
> 2.6.11-rc1 and it appears to work.

Nice. Have you checked that ethtool performs correctly when you try to
set the link parameters with the new code (+ plug/unplug cable) ?

> Attached is the patch against 2.6.11-rc1. I'm not sure if it caters to 
> your tastes. Maybe you'll want to rename RTL_GIGA_MAC_VER_X. 

I'll change the braces placement, the tab/spaces mix and push it.

Please include something like the line below in your future patches:
Signed-off-by: Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx>

Thanks.

--
Ueimor

<Prev in Thread] Current Thread [Next in Thread>