netdev
[Top] [All Lists]

Re: [XFRM] Probe selected algorithm only

To: James Morris <jmorris@xxxxxxxxxx>
Subject: Re: [XFRM] Probe selected algorithm only
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 22 Jan 2005 09:45:46 +1100
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <Xine.LNX.4.44.0501210901001.6594-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20050121101938.GA1133@xxxxxxxxxxxxxxxxxxx> <Xine.LNX.4.44.0501210901001.6594-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Fri, Jan 21, 2005 at 09:01:41AM -0500, James Morris wrote:
> On Fri, 21 Jan 2005, Herbert Xu wrote:
 > 
> > This patch removes an annoying problem in xfrm_user.  As it is every
> > time an SA is added it probes every known algorithm in the universe.
> > Now if they all existed it would be OK.  However, for the ones which
> > don't actually exist this causes multiple /sbin/modprobe processes to
> > be spawned which slows the system down when you're adding hundreds of
> > SAs.
> > 
> > Since we know the type of algorithm required when we're adding a new
> > SA, we can get away with only probing the selected algorithms.  This
> > is what the following patch does for xfrm_user.
> > 
> > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> 
> Looks good to me.
> 
> Signed-off-by: James Morris <jmorris@xxxxxxxxxx>

Sorry, I forgot to update the calls in af_key.  Here is the corrected
version.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>