netdev
[Top] [All Lists]

Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state

To: David Dillow <dave@xxxxxxxxxxxxxx>
Subject: Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 21 Jan 2005 14:38:57 -0800
Cc: netdev@xxxxxxxxxxx, dave@xxxxxxxxxxxxxx
In-reply-to: <20041230035000.10@xxxxxxxxxxxxxxxxxx>
References: <20041230035000.01@xxxxxxxxxxxxxxxxxx> <20041230035000.10@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 30 Dec 2004 03:48:34 -0500
David Dillow <dave@xxxxxxxxxxxxxx> wrote:

> # This is a BitKeeper generated diff -Nru style patch.
> #
> # ChangeSet
> #   2004/12/30 00:27:15-05:00 dave@xxxxxxxxxxxxxx 
> #   Add direction information to xfrm_state. This will be needed to
> #   offload xfrm processing to the NIC.

And xfrm_state, when actually used, does not exist in a vacuum.
It is being used in terms of a particular xfrm_policy which has
a direction indicator already.

Given that, it seems the xfrm_state is not only unnecessary, but
also slightly illogical in fact.  If you need the direction, you
should make sure that at those places you can get back to the
policy in order to obtain that piece of information.

<Prev in Thread] Current Thread [Next in Thread>