Re: [PATCH 21/39] net/ipconfig: replace schedule

netdev

Re: [PATCH 21/39] net/ipconfig: replace schedule_timeout() with msleep()

To:	Nishanth Aravamudan <nacc@xxxxxxxxxx>
Subject:	Re: [PATCH 21/39] net/ipconfig: replace schedule_timeout() with msleep()
From:	James Morris <jmorris@xxxxxxxxxx>
Date:	Thu, 20 Jan 2005 21:36:42 -0500 (EST)
Cc:	davem@xxxxxxxxxxxxx, <kuznet@xxxxxxxxxxxxx>, <yoshfuji@xxxxxxxxxxxxxx>, <kaber@xxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, <kernel-janitors@xxxxxxxxxxxxxx>
In-reply-to:	<20050120235749.GJ2600@xxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx

On Thu, 20 Jan 2005, Nishanth Aravamudan wrote:

> Hi,
> 
> Please consider applying.
> 
> Description: Use msleep() instead of schedule_timeout() to guarantee the task
> delays as expected. Change the units of the two constants to be msecs and secs
> respectively.

Looks fine to me.


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 21/39] net/ipconfig: replace schedule_timeout() with msleep(), Nishanth Aravamudan Re: [PATCH 21/39] net/ipconfig: replace schedule_timeout() with msleep(), James Morris <=

Previous by Date:	Fix fallout from tg3_readphy() value is zero on error, Peter Chubb
Next by Date:	[PATCH 0/12] remove sk_protinfo series, Arnaldo Carvalho de Melo
Previous by Thread:	[PATCH 21/39] net/ipconfig: replace schedule_timeout() with msleep(), Nishanth Aravamudan
Next by Thread:	[PATCH 20/39] net/ip_vs_sync: replace schedule_timeout() with ssleep(), Nishanth Aravamudan
Indexes:	[Date] [Thread] [Top] [All Lists]