netdev
[Top] [All Lists]

Re: [PATCH 2.6.10] tg3: add tg3_set_eeprom

To: "Michael Chan" <mchan@xxxxxxxxxxxx>
Subject: Re: [PATCH 2.6.10] tg3: add tg3_set_eeprom
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 20 Jan 2005 15:05:19 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <B1508D50A0692F42B217C22C02D84972020F3D2E@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <B1508D50A0692F42B217C22C02D84972020F3D2E@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 20 Jan 2005 14:52:14 -0800
"Michael Chan" <mchan@xxxxxxxxxxxx> wrote:

> Add tg3_set_eeprom routine to support configuration changes (e.g. ASF
> config).
> 
> Made changes to other nvram related routines.

Why were the NVRAM_ACCESS writes change to non-flushing register
writes?  Otherwise I think your patch is fine.

Maybe it would be nice if you provided a detailed changelog
of sorts, because other's might have similar questions like I
did about why the tw32_f() --> tw32() changes were made.



<Prev in Thread] Current Thread [Next in Thread>