[Top] [All Lists]

Re: [openib-general] Re: LLTX and netif_stop_queue

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [openib-general] Re: LLTX and netif_stop_queue
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Wed, 19 Jan 2005 15:18:53 -0800
Cc: hadi@xxxxxxxxxx, iod00d@xxxxxx, eric.lemoine@xxxxxxxxx, roland@xxxxxxxxxxx, netdev@xxxxxxxxxxx, ak@xxxxxxx, openib-general@xxxxxxxxxx, kaber@xxxxxxxxx
In-reply-to: <20050119144711.3fdd3d93.davem@xxxxxxxxxxxxx>
Organization: Open Source Development Lab
References: <5cac192f0412230110628749e3@xxxxxxxxxxxxxx> <41CAF444.3000305@xxxxxxxxx> <5cac192f04122408102129af43@xxxxxxxxxxxxxx> <1104240717.1100.66.camel@xxxxxxxxxxxxxxxx> <5cac192f0501021530672a908a@xxxxxxxxxxxxxx> <1104764660.1048.578.camel@xxxxxxxxxxxxxxxx> <52brc68q05.fsf@xxxxxxxxxxx> <5cac192f05010308414a25b548@xxxxxxxxxxxxxx> <527jmu8nbw.fsf@xxxxxxxxxxx> <5cac192f0501030907c755135@xxxxxxxxxxxxxx> <20050103171227.GD7370@xxxxxxxxxxxxxxxxx> <1104812294.1085.53.camel@xxxxxxxxxxxxxxxx> <20050119144711.3fdd3d93.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 19 Jan 2005 14:47:11 -0800
"David S. Miller" <davem@xxxxxxxxxxxxx> wrote:

> On 03 Jan 2005 23:18:14 -0500
> jamal <hadi@xxxxxxxxxx> wrote:
> > On Mon, 2005-01-03 at 12:12, Grant Grundler wrote:
> > 
> > > Some workloads that Jamal cares about (routing) only need 2 cpus.
> > 
> > What bothers me is more the complexity this has introduced more than
> > the workload. OTOH, 1-2% improvement posted by Roland is good
> > justification.
> I think I'm going to put in something like Eric's patch and fix
> up the other LLTX drivers as per his sungem patch.
> There is a part of me that does want to yank LLTX for non-loopback
> out of the tree.

Wondering, why not just have the drivers have a way to lock dev->queue_lock
in the interrupt handler, and change the xmit to do spin_lock_irqsave?

Any driver that assumes it is being called with irq's enabled in transmit
is probably already busted anyway.

Stephen Hemminger       <shemminger@xxxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>