| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [DEBUG]: sk_forward_alloc assertion failures |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Tue, 18 Jan 2005 07:40:38 +1100 |
| Cc: | anton@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050117123729.526ccdc7.davem@xxxxxxxxxxxxx> |
| References: | <20050114203452.GA1277@xxxxxxxxxxxxxxxxxxx> <20050114132757.4ca3153a.davem@xxxxxxxxxxxxx> <20050114213829.GA12454@xxxxxxxxxxxxxxxxxxx> <20050114133611.69ff0bb2.davem@xxxxxxxxxxxxx> <20050114215504.GA12569@xxxxxxxxxxxxxxxxxxx> <20050114140426.5cf06f0c.davem@xxxxxxxxxxxxx> <20050114224745.GA13180@xxxxxxxxxxxxxxxxxxx> <20050114205543.5acb0d68.davem@xxxxxxxxxxxxx> <20050115054547.GA15860@xxxxxxxxxxxxxxxxxxx> <20050117123729.526ccdc7.davem@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040722i |
On Mon, Jan 17, 2005 at 12:37:29PM -0800, David S. Miller wrote: > On Sat, 15 Jan 2005 16:45:47 +1100 > Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > > > + if (sk->sk_forward_alloc < copy && > > > + !sk_stream_mem_schedule(sk, copy, 0)) > > > > You want to have sk->sk_allocation here instead of 0. > > The third argument to sk_stream_mem_schedule() is "int kind" > which is to be set to 1 for receive packet allocations and 0 > for send packet allocations. > > Why would I want to use a sk_allocation gfp mask here? :-) You're right. I got carried away there :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| Previous by Date: | Re: [DEBUG]: sk_forward_alloc assertion failures, David S. Miller |
|---|---|
| Next by Date: | Re: [BK PATCH] sk_dst_cache annotation, David S. Miller |
| Previous by Thread: | Re: [DEBUG]: sk_forward_alloc assertion failures, David S. Miller |
| Next by Thread: | Re: [DEBUG]: sk_forward_alloc assertion failures, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |