| To: | hadi@xxxxxxxxxx |
|---|---|
| Subject: | Re: path: module replay |
| From: | Patrick McHardy <kaber@xxxxxxxxx> |
| Date: | Sun, 16 Jan 2005 20:50:08 +0100 |
| Cc: | Thomas Graf <tgraf@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <41EAC3EE.1020801@xxxxxxxxx> |
| References: | <1105900522.1090.798.camel@xxxxxxxxxxxxxxxx> <41EAB74F.6060507@xxxxxxxxx> <20050116185630.GZ26856@xxxxxxxxxxxxxx> <1105903033.1097.829.camel@xxxxxxxxxxxxxxxx> <1105903960.1097.836.camel@xxxxxxxxxxxxxxxx> <41EAC3EE.1020801@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041008 Debian/1.7.3-5 |
Patrick McHardy wrote: jamal wrote:Ok, here is the last patch. I think module replay should be done from that spot and to be consistent as well from cls_api.c for legacy stuff.I also fixed a module ref count leak. the act_api piece is dependent on what i sent earlier for namsiz.the cls_api change i believe conflicts with what Thomas sent yesterday.We have to replay all orders since we dropped the rtnl. An action could have done __dev_get_by_* or something similar. Can you send a single patch for the module refcount leak please ? I was wrong, the already initialized actions need to hold their own references anyway. I'm going have another look and add your patch later if I don't see other problems. Regards Patrick |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: path: module replay, Patrick McHardy |
|---|---|
| Next by Date: | Re: tunneling in linux (was: Re: [PATCH][RFC] etherip: Ethernet-in-IPv4 tunneling), Pekka Savola |
| Previous by Thread: | Re: path: module replay, Patrick McHardy |
| Next by Thread: | Re: path: module replay, Patrick McHardy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |