[Top] [All Lists]

Re: patch: tc action cleanups

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: patch: tc action cleanups
From: jamal <hadi@xxxxxxxxxx>
Date: 16 Jan 2005 13:41:53 -0500
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <41EAB296.3090504@xxxxxxxxx>
Organization: jamalopolous
References: <1105899636.1090.794.camel@xxxxxxxxxxxxxxxx> <41EAB296.3090504@xxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 2005-01-16 at 13:29, Patrick McHardy wrote:
> jamal wrote:
> >Heres one i think you didnt resurect Patrick. If ok, Dave please apply.
> >Other than that i cant seem to find anything at issue with the core
> >(havent looked at the individual actions other than to follow changed
> >code from the core).
> >
> bindcnt/refcnt changes are protected by the rtnl, no need for extra locking.
> The lock only needs to protect data shared with the "act" function.

Very clever ;-> maybe add a comment then to that effect in your next
batch? Dave ignore that patch.


<Prev in Thread] Current Thread [Next in Thread>