netdev
[Top] [All Lists]

Re: "Badness" again

To: davem@xxxxxxxxxxxxx
Subject: Re: "Badness" again
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Sat, 15 Jan 2005 14:13:53 +0900 (JST)
Cc: herbert@xxxxxxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <20050114210651.654b22de.davem@xxxxxxxxxxxxx>
Organization: USAGI Project
References: <41E844AC.6040200@xxxxxxxxx> <20050115002638.GA13849@xxxxxxxxxxxxxxxxxxx> <20050114210651.654b22de.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <20050114210651.654b22de.davem@xxxxxxxxxxxxx> (at Fri, 14 Jan 2005 
21:06:51 -0800), "David S. Miller" <davem@xxxxxxxxxxxxx> says:

> On Sat, 15 Jan 2005 11:26:38 +1100
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > All your "badness" messages start with a call to udpv6_sendmsg().
> > That function calls ip6_dst_lookup() to get its dst entry.  Note
> > that udpv6_sendmsg() does not hold a lock on the sk at all.  However,
> > ip6_dst_lookup() uses __sk_dst_check() which is only safe if you can
> > either guarantee single-threadedness or if you hold sk_dst_lock.
> 
> Good catch, that looks to be it.

I agree too; this is one of changeset what I was going to send.
Thanks.

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>