netdev
[Top] [All Lists]

Re: race in net/ipv4/ipip.c ?

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: race in net/ipv4/ipip.c ?
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Wed, 12 Jan 2005 11:02:10 -0800
Cc: yoshfuji@xxxxxxxxxxxxxx, buytenh@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050112132126.GI26856@xxxxxxxxxxxxxx>
References: <20050112122300.GA12155@xxxxxxxxxxxxxxxxx> <20050112125336.GH26856@xxxxxxxxxxxxxx> <20050112130940.GA12547@xxxxxxxxxxxxxxxxx> <20050112122300.GA12155@xxxxxxxxxxxxxxxxx> <20050112125336.GH26856@xxxxxxxxxxxxxx> <20050112.220816.56650893.yoshfuji@xxxxxxxxxxxxxx> <20050112132126.GI26856@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 12 Jan 2005 14:21:26 +0100
Thomas Graf <tgraf@xxxxxxx> wrote:

> * YOSHIFUJI Hideaki / ?$B5HF#1QL@ 
> <20050112.220816.56650893.yoshfuji@xxxxxxxxxxxxxx> 2005-01-12 22:08
> > How about adding multiple tunnels (with same ipip_bucket(t))
> > concurrently? :-)
> > 
> 
> * Lennert Buytenhek <20050112130940.GA12547@xxxxxxxxxxxxxxxxx> 2005-01-12 
> 14:09
> > What if you add two tunnels at the same time?  (Or is that perhaps
> > synchronised on a higher level?)
> 
> Not possible, protected via rtnl semaphore acquired in default
> handler of dev_ioctl.

Yeah.  Alexey does this trick everywhere, when we have the RTNL semaphore
held we only need to lock for the actual linkage operation that adds the
new object to the tree.


<Prev in Thread] Current Thread [Next in Thread>