netdev
[Top] [All Lists]

[patch 10/19] net/ns83820: replace schedule_timeout() with msleep()

To: jgarzik@xxxxxxxxx
Subject: [patch 10/19] net/ns83820: replace schedule_timeout() with msleep()
From: domen@xxxxxxxxxxxx
Date: Wed, 12 Jan 2005 00:10:37 +0100
Cc: netdev@xxxxxxxxxxx, domen@xxxxxxxxxxxx, nacc@xxxxxxxxxx, janitor@xxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx


Any comments would be appreciated.

Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Signed-off-by: Maximilian Attems <janitor@xxxxxxxxxxxxxx>
Signed-off-by: Domen Puncer <domen@xxxxxxxxxxxx>
---


 kj-domen/drivers/net/ns83820.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN drivers/net/ns83820.c~msleep-drivers_net_ns83820 drivers/net/ns83820.c
--- kj/drivers/net/ns83820.c~msleep-drivers_net_ns83820 2005-01-10 
18:00:02.000000000 +0100
+++ kj-domen/drivers/net/ns83820.c      2005-01-10 18:00:02.000000000 +0100
@@ -2007,8 +2007,7 @@ static int __devinit ns83820_init_one(st
        if (reset_phy) {
                printk(KERN_INFO "%s: resetting phy\n", ndev->name);
                writel(dev->CFG_cache | CFG_PHY_RST, dev->base + CFG);
-               set_current_state(TASK_UNINTERRUPTIBLE);
-               schedule_timeout((HZ+99)/100);
+               msleep(10);
                writel(dev->CFG_cache, dev->base + CFG);
        }
 
_

<Prev in Thread] Current Thread [Next in Thread>
  • [patch 10/19] net/ns83820: replace schedule_timeout() with msleep(), domen <=