netdev
[Top] [All Lists]

Re: [PATCH[ via-ircc: fix exit section usage

To: "Randy.Dunlap" <rddunlap@xxxxxxxx>
Subject: Re: [PATCH[ via-ircc: fix exit section usage
From: Jean Tourrilhes <jt@xxxxxxxxxxxxxxxxxx>
Date: Mon, 10 Jan 2005 16:43:54 -0800
Address: HP Labs, 1U-17, 1501 Page Mill road, Palo Alto, CA 94304, USA.
Cc: netdev@xxxxxxxxxxx, jgarzik <jgarzik@xxxxxxxxx>
E-mail: jt@xxxxxxxxxx
In-reply-to: <20050106230803.00714c45.rddunlap@xxxxxxxx>
Organisation: HP Labs Palo Alto
References: <20050106230803.00714c45.rddunlap@xxxxxxxx>
Reply-to: jt@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Thu, Jan 06, 2005 at 11:08:03PM -0800, Randy.Dunlap wrote:
> 
> Fix exit section usage, starting with this Error
> from reference_discarded.pl (make buildcheck):
> Error: ./drivers/net/irda/via-ircc.o .data refers to 000000f8 R_386_32        
>   .exit.text
> 
> Signed-off-by: Randy Dunlap <rddunlap@xxxxxxxx>

        Sounds good to me ;-)

        Jean

> diffstat:=
>  drivers/net/irda/via-ircc.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff -Naurp ./drivers/net/irda/via-ircc.c~irda_via_devexit 
> ./drivers/net/irda/via-ircc.c
> --- ./drivers/net/irda/via-ircc.c~irda_via_devexit    2004-12-24 
> 13:33:47.000000000 -0800
> +++ ./drivers/net/irda/via-ircc.c     2005-01-06 21:18:49.742203456 -0800
> @@ -83,7 +83,7 @@ static struct via_ircc_cb *dev_self[] = 
>  
>  /* Some prototypes */
>  static int via_ircc_open(int i, chipio_t * info, unsigned int id);
> -static int __exit via_ircc_close(struct via_ircc_cb *self);
> +static int via_ircc_close(struct via_ircc_cb *self);
>  static int via_ircc_dma_receive(struct via_ircc_cb *self);
>  static int via_ircc_dma_receive_complete(struct via_ircc_cb *self,
>                                        int iobase);
> @@ -111,7 +111,7 @@ static void hwreset(struct via_ircc_cb *
>  static int via_ircc_dma_xmit(struct via_ircc_cb *self, u16 iobase);
>  static int upload_rxdata(struct via_ircc_cb *self, int iobase);
>  static int __devinit via_init_one (struct pci_dev *pcidev, const struct 
> pci_device_id *id);
> -static void __exit via_remove_one (struct pci_dev *pdev);
> +static void __devexit via_remove_one (struct pci_dev *pdev);
>  
>  /* FIXME : Should use udelay() instead, even if we are x86 only - Jean II */
>  static void iodelay(int udelay)
> @@ -140,7 +140,7 @@ static struct pci_driver via_driver = {
>       .name           = VIA_MODULE_NAME,
>       .id_table       = via_pci_tbl,
>       .probe          = via_init_one,
> -     .remove         = via_remove_one,
> +     .remove         = __devexit_p(via_remove_one),
>  };
>  
>  
> @@ -273,7 +273,7 @@ static int __devinit via_init_one (struc
>   *    Close all configured chips
>   *
>   */
> -static void __exit via_ircc_clean(void)
> +static void via_ircc_clean(void)
>  {
>       int i;
>  
> @@ -285,7 +285,7 @@ static void __exit via_ircc_clean(void)
>       }
>  }
>  
> -static void __exit via_remove_one (struct pci_dev *pdev)
> +static void __devexit via_remove_one (struct pci_dev *pdev)
>  {
>       IRDA_DEBUG(3, "%s()\n", __FUNCTION__);
>  
> @@ -468,7 +468,7 @@ static __devinit int via_ircc_open(int i
>   *    Close driver instance
>   *
>   */
> -static int __exit via_ircc_close(struct via_ircc_cb *self)
> +static int via_ircc_close(struct via_ircc_cb *self)
>  {
>       int iobase;
>  
> 
> ---

<Prev in Thread] Current Thread [Next in Thread>