netdev
[Top] [All Lists]

Re: [PATCH] Problem with recent CMSG_COMPAT_OK fix

To: Olaf Kirch <okir@xxxxxxx>
Subject: Re: [PATCH] Problem with recent CMSG_COMPAT_OK fix
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 10 Jan 2005 12:52:06 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20050104165934.GJ7761@xxxxxxx>
References: <20050104165934.GJ7761@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 4 Jan 2005 17:59:34 +0100
Olaf Kirch <okir@xxxxxxx> wrote:

> The recent fixes for cmsg_len handling seem to break 32bit compatibility
> at least on x86_64. The new CMSG_COMPAT_OK macro requires that cmsg_len
> is greater or equal the size of struct cmsghdr, which is the 64bit
> version of the struct.  The code should really check against the size
> of struct compat_cmsghdr.
> 
> Signed-off-by: Olaf Kirch <okir@xxxxxxx>

Applied, thanks Olaf.

<Prev in Thread] Current Thread [Next in Thread>