| To: | Daniele Venzano <webvenza@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/5] sis900 debugging and revision code |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Thu, 06 Jan 2005 18:35:48 -0500 |
| Cc: | NetDev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <20041212123031.GB16325@xxxxxxxxxxxxxxxxxxxx> |
| References: | <20041212121852.GA16325@xxxxxxxxxxxxxxxxxxxx> <20041212123031.GB16325@xxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922 |
Patches 1, 2, and 5 are OK.For the other two patches, I don't want to deviate from the style that has been standard for years: dev->name prefix, followed by message. It may make greps easier for you, but it becomes a non-standard style and may make existing sysadmin scripts out in the field.
Please resend series without the PFX-where-devname-is-known changes.
Jeff
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2.4.x patchlet, David S. Miller |
|---|---|
| Next by Date: | [PATCH 4/28] net/cosa: replace schedule_timeout() with msleep(), Nishanth Aravamudan |
| Previous by Thread: | Re: 2.4.x patchlet, David S. Miller |
| Next by Thread: | Re: [PATCH 1/5] sis900 debugging and revision code, Daniele Venzano |
| Indexes: | [Date] [Thread] [Top] [All Lists] |