netdev
[Top] [All Lists]

Re: [RFC] Patch to Abstract Ethernet PHY support (using driver model)

To: Andy Fleming <afleming@xxxxxxxxxxxxx>
Subject: Re: [RFC] Patch to Abstract Ethernet PHY support (using driver model)
From: Eugene Surovegin <ebs@xxxxxxxxxxx>
Date: Thu, 6 Jan 2005 09:13:55 -0800
Cc: Netdev <netdev@xxxxxxxxxxx>, Embedded PPC Linux list <linuxppc-embedded@xxxxxxxxxx>, Kumar Gala <kumar.gala@xxxxxxxxxxxxx>
In-reply-to: <20050106070245.GA6539@xxxxxxxxxxxxxxxx>
Mail-followup-to: Andy Fleming <afleming@xxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>, Embedded PPC Linux list <linuxppc-embedded@xxxxxxxxxx>, Kumar Gala <kumar.gala@xxxxxxxxxxxxx>
References: <FC6D9B81-5514-11D9-8D51-000393C30512@xxxxxxxxxxxxx> <A3A281FF-5525-11D9-80ED-000393C30512@xxxxxxxxxxxxx> <20050106070245.GA6539@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.5.1i
On Wed, Jan 05, 2005 at 11:02:45PM -0800, Eugene Surovegin wrote:
> 5) PHY interrupt sharing looks broken. Although you request_irq using 
> SA_SHIRQ flag, in the handler itself you don't detect whether this 
> interrupt is for this PHY or not, and return IRQ_HANDLED. This will 
> result in first registered PHY hijacking IRQs from other PHYs (or 
> devices) sharing the same IRQ line.

Doh, ignore this. I wasn't thinking straight...

--
Eugene

<Prev in Thread] Current Thread [Next in Thread>