netdev
[Top] [All Lists]

Re: [PATCH PKT_SCHED 0/17]: tc action cleanup + fixes

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH PKT_SCHED 0/17]: tc action cleanup + fixes
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Date: Thu, 30 Dec 2004 20:12:04 -0200
Cc: hadi@xxxxxxxxxx, Maillist netdev <netdev@xxxxxxxxxxx>
In-reply-to: <41D3F5EC.9050808@xxxxxxxxx>
Organization: Conectiva S.A.
References: <41D3785F.3040909@xxxxxxxxx> <1104382562.1048.39.camel@xxxxxxxxxxxxxxxx> <41D3F5EC.9050808@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 0.9 (X11/20041103)
Patrick McHardy wrote:
jamal wrote:

Patrick,
Thanks for this cleanup.

Questions/comments:

1)compiler or style issue?

You have a few of fixes from

a)
 if (..){
    single statement here;
}
to:
if (..)
    single statement here;

I always add an extra pair of brace
for lazy reasons (in the back of my mind: incase i want to add another
statement ;->).


Just cleanup, I prefer not to waste too many lines. Saving
space increases readability.

Agreed, whenever I have the chance, I remove such bloat ;)

- Arnaldo

<Prev in Thread] Current Thread [Next in Thread>