netdev
[Top] [All Lists]

Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state

To: David Dillow <dave@xxxxxxxxxxxxxx>
Subject: Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state
From: Jan-Benedict Glaw <jbglaw@xxxxxxxxxx>
Date: Thu, 30 Dec 2004 10:48:39 +0100
Cc: netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20041230035000.10@xxxxxxxxxxxxxxxxxx>
Mail-followup-to: David Dillow <dave@xxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
References: <20041230035000.01@xxxxxxxxxxxxxxxxxx> <20041230035000.10@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
On Thu, 2004-12-30 03:48:34 -0500, David Dillow <dave@xxxxxxxxxxxxxx>
wrote in message <20041230035000.10@xxxxxxxxxxxxxxxxxx>:
> diff -Nru a/include/net/xfrm.h b/include/net/xfrm.h
> --- a/include/net/xfrm.h      2004-12-30 01:12:08 -05:00
> +++ b/include/net/xfrm.h      2004-12-30 01:12:08 -05:00
> @@ -146,6 +146,9 @@
>       /* Private data of this transformer, format is opaque,
>        * interpreted by xfrm_type methods. */
>       void                    *data;
> +
> +     /* Intended direction of this state, used for offloading */
> +     int                     dir;
>  };
>  
>  enum {
> @@ -157,6 +160,12 @@
>       XFRM_STATE_DEAD
>  };
>  
> +enum {
> +     XFRM_STATE_DIR_UNKNOWN,
> +     XFRM_STATE_DIR_IN,
> +     XFRM_STATE_DIR_OUT,
> +};

Any specific reason to first define such a nice enum and then using int
in the struct?

MfG, JBG

-- 
Jan-Benedict Glaw       jbglaw@xxxxxxxxxx    . +49-172-7608481             _ O _
"Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg  _ _ O
 fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!   O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>