netdev
[Top] [All Lists]

Re: [PATCH] PKT_SCHED: dsmark must take care of shared/cloned skbs

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH] PKT_SCHED: dsmark must take care of shared/cloned skbs
From: jamal <hadi@xxxxxxxxxx>
Date: 19 Dec 2004 17:53:41 -0500
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20041219203641.GL17998@xxxxxxxxxxxxxx>
Organization: jamalopolous
References: <20041218170017.GH17998@xxxxxxxxxxxxxx> <1103487827.1048.188.camel@xxxxxxxxxxxxxxxx> <20041219203641.GL17998@xxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 2004-12-19 at 15:36, Thomas Graf wrote:
> * jamal <1103487827.1048.188.camel@xxxxxxxxxxxxxxxx> 2004-12-19 15:23
> > If the qdisc at that level muddies the packet thats fair game - thats
> > what goes out on the wire. So we should leave the code as is.
> 
> Agreed for egress but I think it is needed for stuff like IMQ. It's
> debatable whether we should take care of IMQ and alike though.

You are right, it may cause an issue on an IMQ like device when we have
one in kernel. Hang on to the patch for now is my opinion; "schedulers"
should probably not be mucking with packets once they are queued in
(dsmark aint really a scheduler). We should talk to Werner to see if we
can move that functionality prequeueing ...

cheers,
jamal



<Prev in Thread] Current Thread [Next in Thread>