netdev
[Top] [All Lists]

Re: request_module while holding rtnl semaphore

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: request_module while holding rtnl semaphore
From: Thomas Graf <tgraf@xxxxxxx>
Date: Sun, 12 Dec 2004 18:57:36 +0100
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <41917330.6090002@xxxxxxxxx>
References: <41899DCF.3050804@xxxxxxxxx> <E1CQDcP-0003ff-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041109161126.376f755c.davem@xxxxxxxxxxxxx> <20041110010113.GJ31969@xxxxxxxxxxxxxx> <41916A91.3080107@xxxxxxxxx> <20041110012251.GK31969@xxxxxxxxxxxxxx> <41916F0B.5010809@xxxxxxxxx> <20041110013941.GL31969@xxxxxxxxxxxxxx> <41917330.6090002@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
> >>Assuming all error-paths do proper cleanup, returning -EAGAIN
> >>should always result in the same configuration state as before.
> >I agree but this assumption is wrong, at least for u32.
> >
> It will be true soon :) Anything else is a bug, and a nice
> side-effect of this change is that all those dusty error-paths
> actually get used.

I started working on a patchset to clean up all the error paths,
allow changing all pararmeters for those not supporting it yet
and to add the action bits for tcindex, route, and rsvp. Finishing
it and writing all the test cases to do proper testing will take some
time but I hope to have it ready for early 2.6.11 inclusion.

Just to let you know so we don't do redundant work.

<Prev in Thread] Current Thread [Next in Thread>