Re: [PATCH 1/5] sis900 printk and stack usage audit

[Daniele Venzano <webvenza@xxxxxxxxx>]

On Sat, Dec 11, 2004 at 02:06:21PM -0500, Jeff Garzik wrote:
> >@@ -390,13 +390,6 @@
> >     u8 revision;
> >     char *card_name = card_names[pci_id->driver_data];
> > 
> >-/* when built into the kernel, we only print version if device is found */
> >-#ifndef MODULE
> >-    static int printed_version;
> >-    if (!printed_version++)
> >-            printk(version);
> >-#endif
> >-
> >     /* setup various bits in PCI command register */
> >     ret = pci_enable_device(pci_dev);
> >     if(ret) return ret;
> 
> There is no double-printing.  One is #ifndef MODULE, one is #ifdef MODULE.
> 
> Did you read the comment included in the code you deleted???

My bad, dropped.

-- 
-----------------------------
Daniele Venzano
Web: http://teg.homeunix.org