Re: [patch 1/4] net/ne2k-pci: module_param conversion

[Jeff Garzik <jgarzik@xxxxxxxxx>]

janitor@xxxxxxxxxxxxxx wrote:
> @@ -443,8 +435,7 @@ static void ne2k_pci_reset_8390(struct n
>  {
>         unsigned long reset_start_time = jiffies;
>  
> -	if (debug > 1) printk("%s: Resetting the 8390 t=%ld...",
> -                                                 dev->name, jiffies);
> +       printk(KERN_INFO "%s: Resetting the 8390 t=%ld...", dev->name, jiffies);

The rest of the patch looks OK.

This chunk changes behavior, by removing the 'if' test.

        Jeff