netdev
[Top] [All Lists]

Re: [PATCH] ipconfig schedule fix

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH] ipconfig schedule fix
From: Magnus Damm <magnus.damm@xxxxxxxxx>
Date: Wed, 24 Nov 2004 01:02:33 +0100
Cc: netdev@xxxxxxxxxxx
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=bIO9wbuyRRkVfeDb5DPq3nigyciV7iCPDKm6uZO3MzbabJNJj5H06hdhhiJzoW2FjWxa70NmcwyomIudX78SUi6jWwB/V1AC+tTd7N6WABWwVs2hgnX1Dk3oe3U5r89rEFKfYtJwV7GCoPpjkpCDdFTrV9X9L7tDifJBN9KhL3k=
In-reply-to: <20041123154513.0c950033.davem@xxxxxxxxxxxxx>
References: <aec7e5c3041123145030b75d14@xxxxxxxxxxxxxx> <20041123151855.1864659a.davem@xxxxxxxxxxxxx> <aec7e5c304112315426594dc72@xxxxxxxxxxxxxx> <20041123154513.0c950033.davem@xxxxxxxxxxxxx>
Reply-to: Magnus Damm <magnus.damm@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 23 Nov 2004 15:45:13 -0800, David S. Miller <davem@xxxxxxxxxxxxx> wrote:
> On Wed, 24 Nov 2004 00:42:17 +0100
> 
> 
> Magnus Damm <magnus.damm@xxxxxxxxx> wrote:
> 
> > On Tue, 23 Nov 2004 15:18:55 -0800, David S. Miller <davem@xxxxxxxxxxxxx> 
> > wrote:
> > > On Tue, 23 Nov 2004 23:50:35 +0100
> > >
> > >
> > > Magnus Damm <magnus.damm@xxxxxxxxx> wrote:
> > >
> > > > This simple patch makes the DHCP/BOOTP/RARP code sleep with
> > > > schedule_timeout() instead of hogging the cpu with cpu_relax() in a
> > > > loop. This comes handy when a guest kernel is booted inside QEMU.
> > > > Without the patch, the host operating system will consume cpu time
> > > > busy waiting.
> > >
> > > There are two similar loops involving CONF_PRE_OPEN and CONF_POST_OPEN,
> > > you may wish to hit those while you're at it.
> >
> > Huh? You mean _removing_ the timeouts involving CONF_PRE/POST_OPEN? I
> > thought my patch converted all busy waits into schedule_timeout()...
> > What am I missing?
> 
> No, not removing them, but transforming them likewise into
> schedule_timeout() calls.

Yeah, but isn't the patch already doing that? I tried to find more
occurances of CONF_PRE/POST_OPEN in the
linux-2.6.10-rc2-mm3/net/ipv4/ipconfig.c but I think the patch covers
all of them. Please point out what I am missing, maybe it is getting
too late for me know...

/ magnus

<Prev in Thread] Current Thread [Next in Thread>