netdev
[Top] [All Lists]

Re: [PATCH] ipconfig schedule fix

To: Magnus Damm <magnus.damm@xxxxxxxxx>
Subject: Re: [PATCH] ipconfig schedule fix
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 23 Nov 2004 15:45:13 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <aec7e5c304112315426594dc72@xxxxxxxxxxxxxx>
References: <aec7e5c3041123145030b75d14@xxxxxxxxxxxxxx> <20041123151855.1864659a.davem@xxxxxxxxxxxxx> <aec7e5c304112315426594dc72@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 24 Nov 2004 00:42:17 +0100
Magnus Damm <magnus.damm@xxxxxxxxx> wrote:

> On Tue, 23 Nov 2004 15:18:55 -0800, David S. Miller <davem@xxxxxxxxxxxxx> 
> wrote:
> > On Tue, 23 Nov 2004 23:50:35 +0100
> > 
> > 
> > Magnus Damm <magnus.damm@xxxxxxxxx> wrote:
> > 
> > > This simple patch makes the DHCP/BOOTP/RARP code sleep with
> > > schedule_timeout() instead of hogging the cpu with cpu_relax() in a
> > > loop. This comes handy when a guest kernel is booted inside QEMU.
> > > Without the patch, the host operating system will consume cpu time
> > > busy waiting.
> > 
> > There are two similar loops involving CONF_PRE_OPEN and CONF_POST_OPEN,
> > you may wish to hit those while you're at it.
> 
> Huh? You mean _removing_ the timeouts involving CONF_PRE/POST_OPEN? I
> thought my patch converted all busy waits into schedule_timeout()...
> What am I missing?

No, not removing them, but transforming them likewise into
schedule_timeout() calls.

<Prev in Thread] Current Thread [Next in Thread>