| To: | Roland Dreier <roland@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH][RFC/v1][8/12] Add IPoIB (IP-over-InfiniBand) driver |
| From: | Sam Ravnborg <sam@xxxxxxxxxxxx> |
| Date: | Mon, 22 Nov 2004 20:40:03 +0100 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, openib-general@xxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20041122714.nKCPmH9LMhT0X7WE@xxxxxxxxxxx> |
| Mail-followup-to: | Roland Dreier <roland@xxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, openib-general@xxxxxxxxxx, netdev@xxxxxxxxxxx |
| References: | <20041122713.FnSlYodJYum7s82D@xxxxxxxxxxx> <20041122714.nKCPmH9LMhT0X7WE@xxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6i |
More nitpicking..
Sam
> +++ linux-bk/drivers/infiniband/Makefile 2004-11-21 21:25:56.794775182
> -0800
> @@ -1,2 +1,3 @@
> obj-$(CONFIG_INFINIBAND) += core/
No reason to use $(CONFIG_INFINIBAND) here - it's already done in
drivers/infiniband/Makefile
> +EXTRA_CFLAGS += -Idrivers/infiniband/include
This will get killed if you move the include files...
+
> +obj-$(CONFIG_INFINIBAND_IPOIB) += ib_ipoib.o
> +
> +ib_ipoib-y := ipoib_main.o \
> + ipoib_ib.o \
> + ipoib_multicast.o \
> + ipoib_verbs.o \
> + ipoib_vlan.o
One or two lines.
> +#include <asm/semaphore.h>
> +
> +#include "ipoib_proto.h"
Shoulb be included as the last file - since it's the most local one.
> +
> +#include <ib_verbs.h>
> +#include <ib_pack.h>
> +#include <ib_sa.h>
>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH][6/12][RFC/v1] Add IPoIB (IP-over-InfiniBand) driver, Roland Dreier |
|---|---|
| Next by Date: | Re: [PATCH 2.6 PKT_SCHED]: Fix overflow on 64bit in times reported to userspace by tc actions, Patrick McHardy |
| Previous by Thread: | [PATCH][RFC/v1][8/12] Add IPoIB (IP-over-InfiniBand) driver, Roland Dreier |
| Next by Thread: | Re: [PATCH][RFC/v1][8/12] Add IPoIB (IP-over-InfiniBand) driver, Greg KH |
| Indexes: | [Date] [Thread] [Top] [All Lists] |