netdev
[Top] [All Lists]

Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using

To: James Morris <jmorris@xxxxxxxxxx>
Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 18 Nov 2004 14:34:51 -0800
Cc: chrisw@xxxxxxxx, ross.axe@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, sds@xxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <Xine.LNX.4.44.0411181219590.5236-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <Xine.LNX.4.44.0411181158110.5096-100000@xxxxxxxxxxxxxxxxxxxxxxxx> <Xine.LNX.4.44.0411181219590.5236-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 18 Nov 2004 12:25:21 -0500 (EST)
James Morris <jmorris@xxxxxxxxxx> wrote:

> Updated patch below (with Chris Wright's wrapper idea).
> 
> This now fixes both issues.
> 
> 1) Don't call security_unix_may_send() hook during sendmsg() for 
> SOCK_SEQPACKET, and ensure that sendmsg() can only be called on a 
> connected socket so as not to bypass the security_unix_stream_connect() 
> hook.
> 
> 2) Return -EINVAL if sendto() is called on SOCK_SEQPACKET with an address 
> supplied.
> 
> Please review and apply if ok.
> 
> 
> Signed-off-by: James Morris <jmorris@xxxxxxxxxx>

Looks good, applied thanks James.

<Prev in Thread] Current Thread [Next in Thread>