netdev
[Top] [All Lists]

Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using

To: James Morris <jmorris@xxxxxxxxxx>
Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET
From: Chris Wright <chrisw@xxxxxxxx>
Date: Thu, 18 Nov 2004 09:07:06 -0800
Cc: Chris Wright <chrisw@xxxxxxxx>, Ross Kendall Axe <ross.axe@xxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, Stephen Smalley <sds@xxxxxxxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <Xine.LNX.4.44.0411181158110.5096-100000@xxxxxxxxxxxxxxxxxxxxxxxx>; from jmorris@xxxxxxxxxx on Thu, Nov 18, 2004 at 12:01:34PM -0500
References: <20041118084449.Z14339@xxxxxxxxxxxxxxxxxx> <Xine.LNX.4.44.0411181158110.5096-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
* James Morris (jmorris@xxxxxxxxxx) wrote:
> On Thu, 18 Nov 2004, Chris Wright wrote:
> 
> > Why not make a unix_seq_sendmsg, which is a very small wrapper?
> 
> Good idea, patch forthcoming.
> 
> > Does the above stop the other issue?  My laptop died, so I'm not able to
> > test ATM.
> 
> No, it seems to be caused when addrlen in sendto() is non-zero, causing 
> unix_find_other() to be called instead of unix_peer_get(), which is 
> screwing up reference counts.

Right, but the snippet I posted guards against that I think.  It forces
unix_peer_get() in dgram_sendmsg.

> As for MSG_EOR, apart from the generic socket code, nothing is being done.  
> This would be a separate issue.

Yup, just noting the bits that looked broken to me.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

<Prev in Thread] Current Thread [Next in Thread>