Re: [PATCH] (7/23) sk98: basic ethtool support

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Nov 11, 2004 at 03:55:03PM -0800, Stephen Hemminger wrote:
> The basic stuff comes from the newer code from SysKonnect, but I redid
> it using ethtool_ops and a cleaner way of doing the stats (from e100)


> +/*****************************************************************************
> + *
> + *   getSettings - retrieves the current settings of the selected adapter
> + *
> + * Description:
> + *   The current configuration of the selected adapter is returned.
> + *   This configuration involves a)speed, b)duplex and c)autoneg plus
> + *   a number of other variables.
> + *
> + * Returns:    always 0
> + *
> + */

Please use normal kernel-doc function documentation.
 
> +static int getSettings(struct net_device *dev, struct ethtool_cmd *ecmd)

And avoid studlyCaps.  Also an sk98lin prefix even on private function
helps avoiding nameclashes for the generic names (and in the debugger
or oopses)

> +{
> +     const DEV_NET *pNet = netdev_priv(dev);

please always use struct net_device instead of strange typedefs for it.