Re: [PATCH] (13/23) sk98: handle ring full correctly

[Tommy Christensen <tommy.christensen@xxxxxxxxx>]

On Fri, 2004-11-12 at 01:00, Stephen Hemminger wrote:
> This driver needs to manage it's transmit queue properly.
> The hard_start_xmit needs to return OK if send successfully
> and BUSY (1) if queue is full. In either case must free skb,
> existing code would leak if tx ring filled!

This isn't true. When returning NETDEV_TX_BUSY, the caller
will requeue or drop the skb. So

> +     /* Transmit failed, out of resources */
> +     if (rc < 0) {
> +             dev_kfree_skb(skb);
> +             return NETDEV_TX_BUSY;
> +     } else {
> +             dev->trans_start = jiffies;             
> +             return NETDEV_TX_OK;
> +     }

it shouldn't be freed here.

-Tommy