| To: | Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6] ixgb: fix ixgb_intr looping checks |
| From: | Andrew Morton <akpm@xxxxxxxx> |
| Date: | Wed, 10 Nov 2004 11:19:33 -0800 |
| Cc: | jesse.brandeburg@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <Pine.LNX.4.44.0411101712080.16936-100000@xxxxxxxxxxxxxxxxxxxxx> |
| References: | <20041108151048.4bf605c1.akpm@xxxxxxxx> <Pine.LNX.4.44.0411101712080.16936-100000@xxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx> wrote: > > On Mon, 8 Nov 2004, Andrew Morton wrote: > > > This patch undoes a change that we believe will impact performance > > adversely, > > > by creating possibly too long a delay between servicing completions. > > > > Maybe. But now take a look at how much additional pointless work will be > > done in the common case. For instance, every tx completion will incur a > > call to ixgb_clean_rx_irq(), which then calls ixgb_alloc_rx_buffers(). > > Is your common case transmits only? hm, good question. Usually not, I guess. IIRC TCP normally runs with 2Tx:1Rx. NFS-over-UDP will send and receive a lot of back-to-back frames. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [BK PATCH] Misc IPv6 Updates, Krishna Kumar |
|---|---|
| Next by Date: | [patch] gcc-4.0 fix for acenic, Randolph Chung |
| Previous by Thread: | Re: [PATCH 2.6] ixgb: fix ixgb_intr looping checks, Jesse Brandeburg |
| Next by Thread: | [NETLINK] introduce netlink bucket, Pablo Neira |
| Indexes: | [Date] [Thread] [Top] [All Lists] |