netdev
[Top] [All Lists]

Re: request_module while holding rtnl semaphore

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: request_module while holding rtnl semaphore
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Wed, 10 Nov 2004 02:47:28 +0100
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20041110013941.GL31969@xxxxxxxxxxxxxx>
References: <41899DCF.3050804@xxxxxxxxx> <E1CQDcP-0003ff-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041109161126.376f755c.davem@xxxxxxxxxxxxx> <20041110010113.GJ31969@xxxxxxxxxxxxxx> <41916A91.3080107@xxxxxxxxx> <20041110012251.GK31969@xxxxxxxxxxxxxx> <41916F0B.5010809@xxxxxxxxx> <20041110013941.GL31969@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041008 Debian/1.7.3-5
Thomas Graf wrote:

* Patrick McHardy <41916F0B.5010809@xxxxxxxxx> 2004-11-10 02:29
Assuming all error-paths do proper cleanup, returning -EAGAIN
should always result in the same configuration state as before.

I agree but this assumption is wrong, at least for u32.

It will be true soon :) Anything else is a bug, and a nice
side-effect of this change is that all those dusty error-paths
actually get used.

I agree
that once this is true it would work perfectly fine, however I think it would be inefficient to parse the whole TLV tree multiple
times.
It will only happen once for every module, so I don't think
it's a big deal.

Regards
Patrick


<Prev in Thread] Current Thread [Next in Thread>