Re: PROBLEM: IProute hangs after running traffic shaping scripts

[Thomas Graf <tgraf@xxxxxxx>]

> +     /* unlink inner qdiscs from dev->qdisc_list immediately */
> +     if (qdisc->ops->cl_ops != NULL)
> +             list_add(&qdisc->list, &cql);

I think you should extend the above to:

if (qdisc->ops->cl_ops != NULL && !list_empty(&qdisc->list))

Otherwise you might unlink entries just added before the
rcu callback and it prevents an unneeded attempt to delete
qdiscs for inner classful qdiscs

Otherwise the patch looks very good.