netdev
[Top] [All Lists]

Re: [PATCH] PKT_SCHED: Initialize list field in dummy qdiscs

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH] PKT_SCHED: Initialize list field in dummy qdiscs
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Sun, 07 Nov 2004 19:22:08 +0100
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, spam@xxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx
In-reply-to: <20041107174909.GC31969@xxxxxxxxxxxxxx>
References: <20041105194303.GA12289@xxxxxxxxxxxxxx> <20041106011843.GI12289@xxxxxxxxxxxxxx> <418C2D40.9020300@xxxxxxxxx> <20041106015931.GA28715@xxxxxxxxxxxxxx> <20041106145036.GB28715@xxxxxxxxxxxxxx> <418DE37E.2050504@xxxxxxxxx> <20041107140015.GA31969@xxxxxxxxxxxxxx> <418E4B2E.1070407@xxxxxxxxx> <20041107163330.GB31969@xxxxxxxxxxxxxx> <418E553C.2070006@xxxxxxxxx> <20041107174909.GC31969@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041008 Debian/1.7.3-5
Thomas Graf wrote:

Anyways, I do think we should force the task to be completed, or
at least all the list unlinking, before the rtnl semaphore is given
back.  I'm fine with postponing the deletion of the object but not
to postpone list manipulations even if we cannot reproduce it now.

This is what I'm doing now, your patch to set qdisc->parent makes
this very easy :) Simply remove all qdiscs with
(TC_H_MAJ(q->parent) == TC_H_MAJ(qdisc->handle)) from
dev->qdisc_list when a classful qdisc is destroyed.

Regards
Patrick


<Prev in Thread] Current Thread [Next in Thread>