| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [NET] Fix neighbour tbl->entries race |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Sun, 7 Nov 2004 19:08:39 +1100 |
| Cc: | hadi@xxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20041103155438.07a219ad.davem@xxxxxxxxxxxxx> |
| References: | <20041102112651.GA8633@xxxxxxxxxxxxxxxxxxx> <1099404823.1021.15.camel@xxxxxxxxxxxxxxxx> <20041102203720.GA12108@xxxxxxxxxxxxxxxxxxx> <20041102210259.GA12642@xxxxxxxxxxxxxxxxxxx> <20041102220603.GA13312@xxxxxxxxxxxxxxxxxxx> <20041103155438.07a219ad.davem@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040722i |
On Wed, Nov 03, 2004 at 03:54:38PM -0800, David S. Miller wrote: > > Can you cook up a 2.4.x version of this Herbert? The new neighbour > code is now there too. Sure. BTW this bug is a lot older than the new neighbours code. It's in the very first revision of neighbour.c :) Here is a patch for 2.4. I simply used atomic_read instead of doing atomic_inc_return as in 2.6 since I thought that the downside of going a bit over gc_thresh3 wasn't worth the trouble of back-porting all the atomic_*_return work. Of course if that ever gets backported then we can do what 2.6 does here too. Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/3] r8169: non-NAPI netif_poll_disable removal, Francois Romieu |
|---|---|
| Next by Date: | Re: [PATCH] PKT_SCHED: Initialize list field in dummy qdiscs, Patrick McHardy |
| Previous by Thread: | Re: [NET] Fix neighbour tbl->entries race, David S. Miller |
| Next by Thread: | Re: [NET] Fix neighbour tbl->entries race, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |