netdev
[Top] [All Lists]

Re: [PATCH] UDP select handling of bad checksums.

To: Mitchell Blank Jr <mitch@xxxxxxxxxx>
Subject: Re: [PATCH] UDP select handling of bad checksums.
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Wed, 3 Nov 2004 13:20:46 -0800
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx
In-reply-to: <20041103005253.GA77817@xxxxxxxxxxxxxx>
Organization: Open Source Development Lab
References: <20041102162454.3f153ff0@xxxxxxxxxxxxxxxxx> <20041103005253.GA77817@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 2 Nov 2004 16:52:53 -0800
Mitchell Blank Jr <mitch@xxxxxxxxxx> wrote:

> Stephen Hemminger wrote:
> > This patch addresses the issue of blocking usage of select() by UDP 
> > applications.
> 
> I'm glad to see someone actually putting some code forward in this debate...
> Looks pretty good, but can't you implement this a bit cleaner by just
> wrapping datagram_poll?  Something like:

But the wrapper was bigger and uglier than just doing it.
Especially since UDP doesn't need to connection oriented checks.
So the fast path code in UDP is actually faster than datagram_poll.

> 
> That way you duplicate a lot less code.  It does slightly more work but
> only in the broken !O_NONBLOCK case - the fast path is just as quick.
> 
> -Mitch

<Prev in Thread] Current Thread [Next in Thread>