netdev
[Top] [All Lists]

Re: [TCP] Modular IPv6 support in tcpdiag

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [TCP] Modular IPv6 support in tcpdiag
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 4 Nov 2004 07:34:14 +1100
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20041103122050.50f6f556.davem@xxxxxxxxxxxxx>
References: <20041103094451.GA20220@xxxxxxxxxxxxxxxxxxx> <20041103122050.50f6f556.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Wed, Nov 03, 2004 at 12:20:50PM -0800, David S. Miller wrote:
> 
> Any particular reason you didn't use the same config ifdef
> tests we use for structure layouts?  Ie.
> 
> #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)

If I used that then it'll break when TCPDIAG is built-in and
IPv6 is built as a module.

> I don't see the need for the special new config option.

The user won't see it at all since it's a def_bool.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>