netdev
[Top] [All Lists]

Re: [PATCH] TG3: fiber hw autoneg bounces

To: Mike Waychison <Michael.Waychison@xxxxxxx>
Subject: Re: [PATCH] TG3: fiber hw autoneg bounces
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 1 Nov 2004 17:27:12 -0800
Cc: Brian.Somers@xxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <4182B6A7.90700@xxxxxxx>
References: <4182B6A7.90700@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 29 Oct 2004 17:31:19 -0400
Mike Waychison <Michael.Waychison@xxxxxxx> wrote:

> I've traced it to be caused by the tg3_timer 1 second work noticing that
> MAC_STATUS_LNKSTATE_CHANGED was set, which driver would see as the link
> going down.
> 
> Upon further inspection, it appears that we don't wait long enough
> between setting SG_DIG_CTRL and reading the SG_DIG_STATUS for the result.

How come the bcm5700 Broadcom driver gets away without this
incredibly huge delay?  The touching of the device is absolutely
identical in the tg3 driver to what Broadcom's bcm5700 code
is doing.

I'll apply the patch for now though...

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] TG3: fiber hw autoneg bounces, David S. Miller <=