Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr

netdev

Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len

from [jamal]

To:	Matt Domsch <Matt_Domsch@xxxxxxxx>
Subject:	Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len
From:	jamal <hadi@xxxxxxxxxx>
Date:	01 Nov 2004 16:50:49 -0500
Cc:	Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to:	<20041101204533.GA17279@xxxxxxxxxxxxxxxxx>
Organization:	jamalopolous
References:	<20041030013700.GA21540@xxxxxxxxxxxxxxxxx> <E1CNiOT-0008GU-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041030030936.GA25102@xxxxxxxxxxxxxxxxx> <1099163419.1039.97.camel@xxxxxxxxxxxxxxxx> <20041101044433.GA18772@xxxxxxxxxxxxxxxxx> <20041101173434.GA12437@xxxxxxxxxxxxxxxxx> <20041101202754.GA23149@xxxxxxxxxxxxxxxxxxx> <20041101203821.GA15086@xxxxxxxxxxxxxxxxx> <20041101204131.GA23277@xxxxxxxxxxxxxxxxxxx> <20041101204533.GA17279@xxxxxxxxxxxxxxxxx>
Reply-to:	hadi@xxxxxxxxxx
Sender:	netdev-bounce@xxxxxxxxxxx

My onluy comment is on use of -EOVERFLOW which i have seen only
being used in the context of floating point computation
(same as -EUNDERFLOW). I dont know what the right thing to return would
be.

cheers,
jamal

On Mon, 2004-11-01 at 15:45, Matt Domsch wrote:
> On Tue, Nov 02, 2004 at 07:41:31AM +1100, Herbert Xu wrote:
> > You don't need the min anymore since you've checked that dev->addr_len
> > is not greater than sizeof ifr->ifr_hwaddr.sa_data.
> 
> Good catch.
> 
> Signed-off-by: Matt Domsch <Matt_Domsch@xxxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Herbert Xu Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Herbert Xu Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, jamal <= Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Herbert Xu Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, David S. Miller Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Herbert Xu

Previous by Date:	Re: Small Help required!!!, David Stevens
Next by Date:	*Re: [PATCH] remove dead skb_iter functions*, Christoph Hellwig*
Previous by Thread:	Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch
Next by Thread:	Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch
Indexes:	[Date] [Thread] [Top] [All Lists]