Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Mon, Nov 01, 2004 at 11:34:34AM -0600, Matt Domsch wrote:
>
> +                     else if (!dev->addr_len)
> +                             memset(ifr->ifr_hwaddr.sa_data, 0, sizeof 
> ifr->ifr_hwaddr.sa_data);
> +                     else
> +                             memcpy(ifr->ifr_hwaddr.sa_data, dev->dev_addr,
> +                                    min(sizeof ifr->ifr_hwaddr.sa_data, 
> (size_t) dev->addr_len));

Same problem as before.  If dev->addr_len is greater than zero but less
than sizeof ifr->ifr_hwaddr.sa_data, then you've got garbage in there.
Zero is not a special case.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt